test(rocprofiler-sdk/aqlprofile): migrate aqlprofile ctrl test#8044
test(rocprofiler-sdk/aqlprofile): migrate aqlprofile ctrl test#8044MythreyaK wants to merge 8 commits into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Docs:
Title used,
removing label "Not ready to Review" |
Motivation
Migrate the legacy aqlprofile
ctrltest fromprojects/aqlprofile/testinto the in-tree aqlprofile atprojects/rocprofiler-sdk/source/lib/aqlprofile/tests/ctrl, so the test builds with the SDK and exercises the migrated in-tree aqlprofile implementation rather than the installedlibhsa-amd-aqlprofile64.so.Technical Details
app/,ctrl/,pgen/,simple_convolution/,util/, run scripts) intosource/lib/aqlprofile/tests/ctrl;util/hsa_rsrc_factory.*andreg_offsets.hare relative symlinks into the in-treelib/aqlprofile/util.lib/aqlprofile/aqlprofile.hpp,lib/aqlprofile/core/spm_common.hpp).tests/ctrl/CMakeLists.txt(gated onROCPROFILER_BUILD_TESTS): compiles the kernel viagenerate_hsaco, builds thectrlexe linked statically againstrocprofiler-sdk-aqlprofile, and registers one CTest per exercised mode (tests.integration.aqlprofile.ctrl.{dry,pmc,sqtt,pcsmp}).ctrl/hsa_initshim that populates the HSA core/amd-ext tables and routes the v1 aqlprofile API to the statically-linked in-tree symbols, so no shared library is needed (consistent with dropping the standalone.so).run.sh/run_priv.share kept for manual driving.JIRA ID
Test Plan
ctest -R tests.integration.aqlprofile.ctrl.Test Result
Clean build; 4/4 ctrl tests pass (dry/pmc/sqtt/pcsmp). Verified via
nmthat the in-treehsa_ven_amd_aqlprofile_*symbols are linked into the test binary.Submission Checklist