Skip to content

test(rocprofiler-sdk/aqlprofile): migrate aqlprofile ctrl test#8044

Closed
MythreyaK wants to merge 8 commits into
developfrom
users/mkuriche/aqlprofile-ctrl
Closed

test(rocprofiler-sdk/aqlprofile): migrate aqlprofile ctrl test#8044
MythreyaK wants to merge 8 commits into
developfrom
users/mkuriche/aqlprofile-ctrl

Conversation

@MythreyaK

@MythreyaK MythreyaK commented Jun 30, 2026

Copy link
Copy Markdown
Member

Motivation

Migrate the legacy aqlprofile ctrl test from projects/aqlprofile/test into the in-tree aqlprofile at projects/rocprofiler-sdk/source/lib/aqlprofile/tests/ctrl, so the test builds with the SDK and exercises the migrated in-tree aqlprofile implementation rather than the installed libhsa-amd-aqlprofile64.so.

Technical Details

  • Copied the ctrl test suite (app/, ctrl/, pgen/, simple_convolution/, util/, run scripts) into source/lib/aqlprofile/tests/ctrl; util/hsa_rsrc_factory.* and reg_offsets.h are relative symlinks into the in-tree lib/aqlprofile/util.
  • Updated includes for the migrated layout (lib/aqlprofile/aqlprofile.hpp, lib/aqlprofile/core/spm_common.hpp).
  • Added tests/ctrl/CMakeLists.txt (gated on ROCPROFILER_BUILD_TESTS): compiles the kernel via generate_hsaco, builds the ctrl exe linked statically against rocprofiler-sdk-aqlprofile, and registers one CTest per exercised mode (tests.integration.aqlprofile.ctrl.{dry,pmc,sqtt,pcsmp}).
  • Added a small ctrl/hsa_init shim that populates the HSA core/amd-ext tables and routes the v1 aqlprofile API to the statically-linked in-tree symbols, so no shared library is needed (consistent with dropping the standalone .so).
  • Applied clang-tidy fixes using the SDK config. run.sh/run_priv.sh are kept for manual driving.

JIRA ID

Test Plan

ctest -R tests.integration.aqlprofile.ctrl.

Test Result

Clean build; 4/4 ctrl tests pass (dry/pmc/sqtt/pcsmp). Verified via nm that the in-tree hsa_ven_amd_aqlprofile_* symbols are linked into the test binary.

Submission Checklist

@MythreyaK MythreyaK self-assigned this Jun 30, 2026
@MythreyaK MythreyaK marked this pull request as ready for review June 30, 2026 23:07
@MythreyaK MythreyaK requested review from a team as code owners June 30, 2026 23:07
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
───
Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
JIRA ID : TESTAUTO-6039
JIRA ID - #330
JIRA ID #330
ISSUE ID : TESTUTO-3334
ISSUE ID #3334
ISSUE ID - TESTAUTO-3433
ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
Closes #10
Fixes octo-org/octo-repo#100
Resolves: #123
#123
https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@MythreyaK

Copy link
Copy Markdown
Member Author

Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description

Docs:

type(optional-scope): short description
Allowed types:
...
test Adding or fixing tests

Title used,

test(rocprofiler-sdk/aqlprofile): migrate aqlprofile ctrl test

removing label "Not ready to Review"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant