Repository navigation
Conversation
The Windows RMT build restores the OGA artifacts with fail-on-cache-miss, keyed by OGA_PR_PATCHES. #1335 changed the list in windows-deps.yml, which builds that cache, to "2685 2691 2705 2712 2792 2801", but windows-rmt.yml kept "2685 2691 2705 2712 2763", so its key matches no cache entry and the job fails at "Restore oga-artifacts" on main and every PR. Co-Authored-By: Cursor <cursoragent@cursor.com> Made-with: Cursor Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 8246 - Commit: |
Binary sizesBaseline: run 41196920350 -
MorphiZen EP Performance Results
EPContext Export Performance
EPContext Import Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
VLM Benchmark Results
TTFT / TPS vs mainBaseline: run 41196920350 -
Run: 8246 - Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Windows RMT Build fails at "Restore oga-artifacts" on main and every PR. This syncs
OGA_PR_PATCHESinwindows-rmt.ymlwithwindows-deps.yml.Related issue or design
None.
Why
windows-rmt.ymlrestores the OGA artifacts withfail-on-cache-miss: true, keyed byOGA_PR_PATCHES. #1335 changed the list inwindows-deps.yml, which builds that cache, to2685 2691 2705 2712 2792 2801.windows-rmt.ymlkept2685 2691 2705 2712 2763, so it asks forwindows-oga-0.17.0-pr2685 2691 2705 2712 2763-ort1.31.0-ortpr, which does not exist. The only Windows OGA cache entry iswindows-oga-0.17.0-pr2685 2691 2705 2712 2792 2801-ort1.31.0-ortpr.What
windows-rmt.yml:OGA_PR_PATCHESnow matcheswindows-deps.yml, with a comment that the two must agree.ONNXRUNTIME_VERSION,ONNXRUNTIME_PR_PATCHESandAMDGPU_EP_REFalready match.Test plan
pre-commit run --files .github/workflows/windows-rmt.yml: all hooks pass.gh cache list --key windows-ogashows the entry the new key resolves to.Checklist
AI assistance: the diagnosis and change were made with Cursor (Claude).