if miopen/hipblas/rocblas are not enabled, send gemms to rocmlir - #5059
Merged
Conversation
bdevorem
force-pushed
the
bdevorem/lower_conv
branch
from
July 13, 2026 18:13
d2a53be to
0957c7e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GPU MLIR fusion routing so that when external GPU libraries (MIOpen / rocBLAS / hipBLASLt) are disabled at build time, convolution and GEMM-like ops are routed through rocMLIR to ensure they are still lowered properly.
Changes:
- Extend
fuse_mlir’s mode selection to force rocMLIR routing for convolution when MIOpen is disabled, and for dot/fused_dot when GEMM libraries are disabled. - Update the dependency/source specification for rocMLIR in
requirements.txt. - Add a changelog entry documenting the behavior change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/targets/gpu/fuse_mlir.cpp | Forces rocMLIR routing for conv/dot under specific “library disabled” build configurations. |
| requirements.txt | Changes how rocMLIR is sourced for builds. |
| CHANGELOG.md | Documents the new routing behavior in the changelog. |
pfultz2
reviewed
Jul 13, 2026
Regressions detected 🔴 |
|
TedThemistokleous
approved these changes
Jul 14, 2026
pfultz2
approved these changes
Jul 14, 2026
bdevorem
force-pushed
the
bdevorem/lower_conv
branch
from
July 15, 2026 15:06
237cf62 to
5a7f298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When external libraries are not enabled, gemm ops need to be sent to rocmlir so they are lowered properly.
Technical Details
Just adds a check for the libraries. If not enabled, then send relevant ops to rocmlir
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.