Skip to content

SM8750 konkr pocket fit elite add joystick stick led support - #3087

Merged
loki666 merged 2 commits into
ROCKNIX:nextfrom
slaide:sm8750-konkr-pfe-stick-rgb
Jul 31, 2026
Merged

SM8750 konkr pocket fit elite add joystick stick led support#3087
loki666 merged 2 commits into
ROCKNIX:nextfrom
slaide:sm8750-konkr-pfe-stick-rgb

Conversation

@slaide

@slaide slaide commented Jul 30, 2026

Copy link
Copy Markdown

Summary

  • What is the goal of this PR? (e.g. Bump up an emulator version, implement a new feature. )

implement support to control the joystick leds on the konkr pocket fit elite

Testing

  • How was this tested? (e.g. Built and tested on specific devices, manual testing steps, URLs for CI/CD build artifacts.)
  • Test results: (e.g. Screenshots, logs, performance metrics if applicable.)

tested on the device via the es joystick led controls. all 3 modes (off/battery/rgb) work fine.

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on.)

the hardware only supports setting the color for both joysticks at once, not individually, and i didnt find a way to tell es that, so the actual rgb color that ends up in the hardware is.. well, see the code. the idea is that you set the color of one joystick to 0/0/0, then the color of the other will control both directly.


AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? YES | PARTIALLY | NO

yes, heavy use of claude

Patrick Hennig added 2 commits July 31, 2026 01:40
Device quirk sets DEVICE_ANALOG_STICKS_LED_CONTROL for the
EmulationStation analog-stick LED menu; bin/analog_sticks_ledcontrol
drives the konkr:rgb:joysticks multicolor LED registered by
konkr_sysbtn. The MCU frame carries one rgb triple for both rings, so
the per-stick colors are combined channel-wise. Boot restore comes
from platform 030-analog_leds.
bin/ledcontrol implements off/rgb/battery for the EmulationStation
LED color list and blanks the rings for led-poweroff.service;
bin/battery_led_status colors them by charge level while that mode
is selected, waiting out the EAGAIN qcom-battmgr returns before its
ADSP link is up. The rings are this device's only LEDs, so both
drive konkr:rgb:joysticks.
@slaide
slaide force-pushed the sm8750-konkr-pfe-stick-rgb branch from 673ceb7 to f6a5cfa Compare July 30, 2026 23:41

@loki666 loki666 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loki666
loki666 added this pull request to the merge queue Jul 31, 2026
Merged via the queue into ROCKNIX:next with commit 1d9ef39 Jul 31, 2026
3 of 4 checks passed
@slaide
slaide deleted the sm8750-konkr-pfe-stick-rgb branch August 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants