Adding a size parameter to klippy(), solving #18 and #27 - #28
Open
AlexisDerumigny wants to merge 1 commit into
Open
Adding a size parameter to klippy(), solving #18 and #27#28AlexisDerumigny wants to merge 1 commit into
size parameter to klippy(), solving #18 and #27#28AlexisDerumigny wants to merge 1 commit into
Conversation
In the `klippy.js` file, there is a function `autoSize` that computes the size of the klippy icon based on the left- or right-padding of the parent. This commit adjusts automatically this padding and therefore the size of the icon, from a `size` parameter given by the user.
|
Please integrate this PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RLesur Thanks for this very nice package! It is very useful, but the klippy button is a bit small compared to my taste (as in #18, #27) .
This PR adds a new parameter
size(in pixels) to the functionklippy(), allowing the user to customize the size (by changing the width) of the button. By default, this size is set toNULLand the (existing) automatic default is used instead.In the
klippy.jsfile, there is a functionautoSizethat computes the size of the klippy icon based on the left- or right-padding of the parent. This commit adjusts automatically this padding and therefore the size of the icon, from asizeparameter given by the user.