c2rust: Use released version - #215
Conversation
|
Reopening after accidentally having deleted the branch. |
|
Huh, saying that this is not where I'd have expected the error to show up would be putting it mildly -- I'm having a look at why this fails, but it may take a while. |
|
I have no clue what caused the build failure, and can not reproduce the issue locally (after building the container in podman and using Let's see if it was a random glitch (like, file system error?), restarting the build test. |
|
Seems that builds break due to files left over from other runs. Switching to draft PR to prevent accidental merging just because a test happens to fix it. |
040c1db to
d2248ab
Compare
|
I suspect now that this is due to changes in some base image, and would break in master just as well. I still can't make progress for lack of a way to reproduce it (works locally), so I'm triggering a master rebuild to cut down the space. |
9038964 to
0e04566
Compare
0e04566 to
6298db0
Compare
6298db0 to
f69bdcb
Compare
| # Something left directories that break things | ||
| # A git clean wouldn't remove repositories | ||
| rm -rf RIOT/build | ||
| # These files can't be removed? | ||
| ls -ld tests/pkg_nanopb/bin/native/core_lib | ||
| ls -l tests/pkg_nanopb/bin/native/core_lib/atomic_c11.d | ||
| rm -rf tests/pkg_nanopb/bin/native/core_lib | ||
| (cd RIOT && git clean -fxd) |
There was a problem hiding this comment.
This got addressed by #290 and RIOT-OS/RIOT#22631
| RUN \ | ||
| echo 'Installing C2Rust' >&2 && \ | ||
| CARGO_HOME=/opt/rustup/.cargo cargo install --no-track --locked c2rust --git https://github.com/chrysn-pull-requests/c2rust --branch riscv-vector-types && \ | ||
| CARGO_HOME=/opt/rustup/.cargo cargo install --no-track --locked c2rust --version 0.17.0 && \ |
There was a problem hiding this comment.
And somewhere along the way this was already done, with #283 we're at 0.22.1 anyways.
|
Everything has been addressed by other PRs, so this can be closed. |
4 participants
This reduces the dependency on a particular GitHub branch that I was already about to remove after immunant/c2rust#693 was done.
Still marked as a draft as it depends on immunant/c2rust#690 (but that has all its blockers gone already).