fix: Disabled states for command item and multi select - #147
Merged
Conversation
|
📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-yfkedritxd.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, disabled items would have no pointer events and therefore wouldn't be able to trigger the disabled tooltip. If you removed the
pointer-events-nonethe tooltip would then have 50% opacity:Screen.Recording.2026-08-21.at.14.11.01.mov
After, now has pointer events to allow the tooltip to be seen and a color of
text-muted-foreground/50to imply the disabled state without affecting the opacity of the tooltip. The menu item is still not able to be selected in this sate:Screen.Recording.2026-08-21.at.14.11.25.mov
Also command palette disabled state:
