feat: NRP-3574 Filter chip component - #144
Open
stavros-tomas wants to merge 5 commits into
Open
Conversation
stavros-tomas
marked this pull request as ready for review
July 31, 2026 14:54
|
📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-nxzepgxgcl.chromatic.com/ |
aidanCQ
reviewed
Jul 31, 2026
| import { Chip, type ChipProps } from "../chip"; | ||
| import { type ComponentPropsWithRef } from "react" | ||
|
|
||
| type FilterChipProps = ComponentPropsWithRef<"div"> & { |
Collaborator
There was a problem hiding this comment.
I'd probably remove the component props types if they don't get passed down.
Collaborator
Author
There was a problem hiding this comment.
Thank you for spotting, no I added this on purpose, this is a reusable library primitive component, all components should do this. The mistake was not to pass the props. I pass them now. Cheers!
|
📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-acllmgvpng.chromatic.com/ |
|
📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-hzlzyrnhpd.chromatic.com/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: