Stack lyrics below art on portrait displays; fix player.js syntax error - #18
Merged
Merged
Conversation
On a vertical monitor the Now Playing screen tried to fit art, info, and lyrics as three columns, squeezing the title to one word per line. In portrait orientation the lyrics now drop below the art + info row as a full-width, centered column. Also fixes a SyntaxError in player.js (`??` mixed with `||` without parentheses in the cue-sheet duration getter) that prevented the renderer from booting at all on the current main. Verified with a live 1080x1920 Xvfb screenshot of the Now Playing screen with a synced .lrc loaded. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0125mBkda6C4Yv2CiekXA6uW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portrait Now Playing
On a vertical monitor the Now Playing screen tried to fit art, info, and lyrics as three columns, squeezing the title to one word per line. Under
@media (orientation: portrait)the lyrics now drop below the art + info row as a full-width, centered column; art is capped by height so the whole thing fits without scrolling the page. Landscape is untouched.Syntax error on main
src/js/player.json currentmainhasc.cueEnd ?? this.el.duration || 0— mixing??with||without parentheses is a hard SyntaxError, so the renderer never booted (blank library, "Nothing playing"). Fixed with explicit parentheses. Every other JS file passes a syntax check.Verification
Live 1080×1920 Xvfb screenshot of the Now Playing screen with a synced
.lrcloaded — art + info row on top, lyrics centered below.🤖 Generated with Claude Code
https://claude.ai/code/session_0125mBkda6C4Yv2CiekXA6uW
Generated by Claude Code