feat(agentic-workflow): add llm_provider_id to the workflow model schemas - #1193
Merged
Merged
Conversation
…emas Lets a workflow take its credential from an existing LLM provider instead of an inline api_key. Nullable and absent by default, so inline configuration is unchanged. Returned in the response, unlike api_key, because it names a credential rather than carrying one.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The response schema has an unresolved moderate contract issue, alongside a minor grammar nit.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds nullable llm_provider_id support to agentic workflow request and response schemas, enabling reuse of existing LLM provider credentials.
Changes:
- Adds the provider UUID to both schemas.
- Documents provider validation and exclusivity with
api_key. - Preserves inline
api_keybehavior when no provider is specified.
File summaries
| File | Summary | Review findings |
|---|---|---|
openapi.yaml |
Updates agentic workflow model request and response schemas. | Nit (1 vote): fix incomplete grammar at line 32155. Moderate (2 votes): require nullable llm_provider_id in responses to distinguish null from omission. |
Review details
Suppressed comments (1)
openapi.yaml:32155
- The phrase "be one the caller may use" is grammatically incomplete. Please change it to "be one that the caller may use" so the provider eligibility requirement is clear.
workflow's organization, be one the caller may use, and match `type`.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+32166
to
+32169
| llm_provider_id: | ||
| type: string | ||
| format: uuid | ||
| nullable: true |
RemiBonnet
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llm_provider_id(nullable uuid) onAgenticWorkflowModelRequestandAgenticWorkflowModelResponseapi_keyconfiguration is unchangedapi_key, because it names a credential rather than carrying oneWhy: an agentic workflow can now take its credential from an existing LLM provider instead of retyping and rotating the key per workflow.
Verified: YAML parses and both schemas expose the field;
spectral:oasfinding count is identical to the baseline (261). The repo's own ruleset URL in.spectral.mjs404s, on this branch and on unmodifiedmainalike, sonpm testcould not run locally.Backend: qovery/backend/q-core!3955
Summary by cubic
Adds
llm_provider_idto theAgenticWorkflowModelRequestandAgenticWorkflowModelResponseschemas, letting workflows reuse an existing LLM provider credential instead of an inlineapi_key.api_keyconfiguration remains unchanged.api_key, because it references a credential rather than carrying it.llm_provider_idandapi_keyare rejected; the provider must belong to the workflow's organization and be usable by the caller.Written for commit da4256a. Summary will update on new commits.