Skip to content

feat(agentic-workflow): add llm_provider_id to the workflow model schemas - #1193

Merged
RemiBonnet merged 1 commit into
mainfrom
feat-agentic-llm-provider-field
Sep 16, 2026
Merged

RemiBonnet merged 1 commit into
mainfrom
feat-agentic-llm-provider-field

Conversation

@fabienfleureau

@fabienfleureau fabienfleureau commented Sep 16, 2026

Copy link
Copy Markdown
Contributor
  • llm_provider_id (nullable uuid) on AgenticWorkflowModelRequest and AgenticWorkflowModelResponse
  • absent by default, so inline api_key configuration is unchanged
  • returned in the response, unlike api_key, because it names a credential rather than carrying one

Why: an agentic workflow can now take its credential from an existing LLM provider instead of retyping and rotating the key per workflow.

Verified: YAML parses and both schemas expose the field; spectral:oas finding count is identical to the baseline (261). The repo's own ruleset URL in .spectral.mjs 404s, on this branch and on unmodified main alike, so npm test could not run locally.

Backend: qovery/backend/q-core!3955


Summary by cubic

Adds llm_provider_id to the AgenticWorkflowModelRequest and AgenticWorkflowModelResponse schemas, letting workflows reuse an existing LLM provider credential instead of an inline api_key.

  • Nullable and absent by default, so inline api_key configuration remains unchanged.
  • Returned in the response, unlike api_key, because it references a credential rather than carrying it.
  • Requests with both llm_provider_id and api_key are rejected; the provider must belong to the workflow's organization and be usable by the caller.

Written for commit da4256a. Summary will update on new commits.

Review in cubic

…emas

Lets a workflow take its credential from an existing LLM provider instead of
an inline api_key. Nullable and absent by default, so inline configuration is
unchanged. Returned in the response, unlike api_key, because it names a
credential rather than carrying one.
Copilot AI lite review requested due to automatic review settings September 16, 2026 07:37

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The response schema has an unresolved moderate contract issue, alongside a minor grammar nit.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds nullable llm_provider_id support to agentic workflow request and response schemas, enabling reuse of existing LLM provider credentials.

Changes:

  • Adds the provider UUID to both schemas.
  • Documents provider validation and exclusivity with api_key.
  • Preserves inline api_key behavior when no provider is specified.
File summaries
File Summary Review findings
openapi.yaml Updates agentic workflow model request and response schemas. Nit (1 vote): fix incomplete grammar at line 32155. Moderate (2 votes): require nullable llm_provider_id in responses to distinguish null from omission.
Review details

Suppressed comments (1)

openapi.yaml:32155

  • The phrase "be one the caller may use" is grammatically incomplete. Please change it to "be one that the caller may use" so the provider eligibility requirement is clear.
            workflow's organization, be one the caller may use, and match `type`.
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread openapi.yaml
Comment on lines +32166 to +32169
llm_provider_id:
type: string
format: uuid
nullable: true
@RemiBonnet
RemiBonnet merged commit 8b629ef into main Sep 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants