Skip to content

feat(llm-provider): add LLM provider endpoints and schemas - #1189

Merged
fabienfleureau merged 2 commits into
mainfrom
feat-agentic-llm-provider-api
Sep 15, 2026
Merged

fabienfleureau merged 2 commits into
mainfrom
feat-agentic-llm-provider-api

Conversation

@fabienfleureau

@fabienfleureau fabienfleureau commented Sep 14, 2026

Copy link
Copy Markdown
Contributor
  • CRUD paths under /organization/{organizationId}/llmProvider and /llmProvider/{llmProviderId}, plus LlmProviderType (CLAUDE, BEDROCK), LlmProviderScope, request/response/list schemas and the llmProviderId parameter.
  • credential is writeOnly and absent from the response, which reports has_credential instead; blank means unchanged on edit.
  • No settings on this contract: provider settings stay on the agentic workflow, so the provider carries only identity, credential and scope.

Why: public contract for the reusable LLM providers added in q-core.

Verified: YAML parses, every $ref resolves, redocly lint diffed against the unmodified baseline — 0 new errors, 1 new tag-description warning consistent with all 123 existing tags. Project spectral ruleset URL 404s on baseline too, so it could not run.

Backend: https://gitlab.com/qovery/backend/q-core/-/merge_requests/3940

Contract for the reusable LLM provider settings added in q-core: CRUD under
/organization/{organizationId}/llmProvider and /llmProvider/{llmProviderId},
CLAUDE and BEDROCK types, opaque settings, and ORGANIZATION or USER scope.

The credential is writeOnly and absent from the response, which reports
has_credential instead. Blank means unchanged on edit.

Co-authored-by: omnigent <noreply@omnigent.ai>
Copilot AI lite review requested due to automatic review settings September 14, 2026 16:44

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Add owner_user_sub and owner_name to the required list while keeping them nullable.

Pull request overview

Adds the public OpenAPI contract for reusable LLM provider settings and CRUD operations.

Changes:

  • Added organization- and provider-scoped CRUD endpoints.
  • Added provider types, scopes, schemas, and llmProviderId.
  • Documented write-only credentials and has_credential response semantics.
File summaries
File Summary
openapi.yaml Defines LLM provider endpoints, parameters, tags, and schemas.
Review details

Suppressed comments (1)

openapi.yaml:21260

  • owner_user_sub and owner_name are documented as present and null for ORGANIZATION providers, but neither field is in required. A schema-valid response can therefore omit the owner metadata entirely, so generated clients cannot rely on the contract described below; add both fields to this required list while keeping them nullable.
          required:
            - name
            - description
            - type
            - settings
            - has_credential
            - scope
            - updated_at
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Provider settings stay on the agentic workflow, so they leave this
contract: the property goes from both schemas, the required entry goes
from the response, and the path and type descriptions no longer describe
the resource as provider settings.

Credentials are unchanged: still writeOnly, still absent from the
response, which keeps reporting has_credential.

Co-authored-by: omnigent <noreply@omnigent.ai>
@fabienfleureau
fabienfleureau merged commit c559a87 into main Sep 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants