Simplify _Q_opt in parmest with block scenario structure.

[sscini]

Fixes # .

Summary/Motivation:

_Q_opt, the main model building and solving function within parmest, is still heavily dependent on MPISPPY, and the code is becoming outdated and difficult to interpret. The goal of this PR is to redesign _Q_opt to work without this dependence, retaining all the current functionality

Changes proposed in this PR:

-_Q_opt redesign, using a block structure, with minimal changes needed to functions that utilize it.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the BSD license.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[sscini]

@djlaky @adowling2 Here are my initial thoughts on the redesign. Please provide feedback on code layout to this point.

[sscini]

Dan and I had a good conversation today about the functional things needed in the redesign, and how to go about adding components to the overall block and sub-models. Working to implement changes, closely related to what is done currently in doe's _generate_scenario_blocks.

[adowling2]

Nice progress

[sscini]

@adowling2 @djlaky Added case for bootstrap, now works with theta_est, theta_est_bootstrap, and theta_est_leaveNout if I replace _Q_opt with _Q_opt_blocks. Please review.

I am aware of the duplicated code, but when I attempted to unify them using n_scenarios = len(self.exp_list) or len(bootlist), I am getting an error for bootstrap I am still working out.

Would we want to fully transition to using theta_est for obj and theta, and cov_est for covariance and add an error/warning? Or should I make it work to calculate cov if calc_cov=True?

Thanks!

[codecov]

Codecov Report

❌ Patch coverage is 88.65979% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.12%. Comparing base (dccdbdd) to head (7547ca4).

Files with missing lines	Patch %	Lines
pyomo/contrib/parmest/parmest.py	87.95%	33 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3789   +/-   ##
=======================================
  Coverage   90.11%   90.12%           
=======================================
  Files         905      905           
  Lines      107502   107490   -12     
=======================================
- Hits        96878    96874    -4     
+ Misses      10624    10616    -8     

Flag	Coverage Δ
builders	29.13% <3.43%> (+<0.01%)	⬆️
default	86.46% <88.65%> (?)
expensive	35.21% <51.54%> (?)
linux	87.61% <88.65%> (-2.00%)	⬇️
linux_other	87.61% <88.65%> (+<0.01%)	⬆️
oldsolvers	28.08% <3.43%> (+0.01%)	⬆️
osx	82.99% <88.65%> (+<0.01%)	⬆️
win	85.53% <88.65%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sscini]

@adowling2 @djlaky Should I tag larger team on this? Please review when available. Thanks!

[sscini]

@mrmundt Please rerun the one failing check. It failed really early.

[slilonfe5]

@blnicho, @mrmundt, I think all of the review comments have been addressed. We would appreciate final comments if there are any, otherwise, I think this looks pretty good.

[mrmundt]

I have two comments about what look like residual comments / blocks, but they aren't critical to remove.

[sscini]

@blnicho Requested changes are applied, please rerun failing tests as the issues are related to windows installation. Thanks!

[sscini]

@blnicho Requested changes are applied, please rerun failing tests as the issues are related to windows installation. Thanks!

This was before I made one more small change. Hopefully new set is all passing.

[sscini]

@blnicho One bad windows check. Please rerun. Thank you!!

[sscini]

@blnicho Please let me know if I need to add a few more tests or good as is. Some of the uncovered portion in the patch is due to me moving the deprecated functions down, and will be addressed soon in a PR. Thank you!