Apply Hermes DNS when storing refreshed macOS WireGuard config - #32
Open
chris-in-the-shell wants to merge 1 commit into
Open
Conversation
chris-in-the-shell
marked this pull request as ready for review
July 1, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply Hermes DNS settings when macOS stores refreshed WireGuard client config during session refresh.
Background
The macOS session refresh path was storing
clientConfig.wireGuardConfigdirectly after fetching VPN properties. That bypassed the existingrefreshConfig()step used by iOS and by the macOS Hermes update event path.As a result, active Hermes/custom DNS resolvers could be missing from the stored WireGuard config until a later Hermes update event refreshed it.
Changes
apps/macos/ProtonVPN/Scenes/Common/Services/AppSessionManager.swift, update the macOS session refresh path to storeclientConfig.wireGuardConfig.refreshConfig()instead of the rawclientConfig.wireGuardConfigretrieveProperties()behavior with the existing iOS session refresh path and the macOS Hermes update event pathapps/macos/ProtonVPNTests/Tests/AppSessionManagerImplementationTests.swift, addAppSessionManagerHermesDNSTeststo cover the silent login/session refresh behaviorVerification
The new regression tests are included in this PR and exercise the session refresh behavior with mocked app dependencies:
vpnApiClient.vpnPropertiesreturnsClientConfig.defaultClientConfigForTests127.0.0.1attemptSilentLogIn()is runpropertiesManager.wireguardConfig.dnsServersvalue is assertedCovered scenarios:
["127.0.0.1", "10.2.0.1"]["10.2.0.1"]["10.2.0.1"]Testing
git diff --checkAppSessionManagerHermesDNSTestsI verified the targeted test locally in a configured macOS/Xcode project environment.
The test is included in this PR and can be run from the PR branch with:
Manual signed-app VPN tunnel verification was not run.