Migrate Pester test suite from v4 to v5

.github/workflows/ci.yml

@@ -1,50 +1,54 @@
 name: CI
-permissions:
-  checks: write
-  pull-requests: write
-  contents: read
 on:
   push:
-    branches: [master]
+    branches: [ master ]
     paths:
-      - 'PSDepend/**'
-      - 'Tests/**'
-      - 'build.ps1'
-      - 'psakeFile.ps1'
-      - 'requirements.psd1'
+      - "PSDepend/**"
+      - "Tests/**"
+      - "build.ps1"
+      - "psakeFile.ps1"
+      - "requirements.psd1"
   pull_request:
     paths:
-      - 'PSDepend/**'
-      - 'Tests/**'
-      - 'build.ps1'
-      - 'psakeFile.ps1'
-      - 'requirements.psd1'
+      - "PSDepend/**"
+      - "Tests/**"
+      - "build.ps1"
+      - "psakeFile.ps1"
+      - "requirements.psd1"
   workflow_dispatch:
 
 jobs:
   test:
     name: Test (${{ matrix.os }})
     runs-on: ${{ matrix.os }}
+    permissions:
+      contents: read
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macOS-latest]
+        os: [ ubuntu-latest, windows-latest, macOS-latest ]
     steps:
       - uses: actions/checkout@v4
-      - name: Bootstrap and Test
+      - name: Bootstrap
         shell: pwsh
-        run: ./build.ps1 -Bootstrap -Task Test
+        run: ./build.ps1 -Bootstrap -Task Init
+      - name: Test
+        shell: pwsh
+        run: ./build.ps1 -Task Test
       - name: Upload Test Results
         if: always()
         uses: actions/upload-artifact@v4
         with:
           name: testResults-${{ matrix.os }}
-          path: ./Output/testResults.xml
+          path: ./Tests/out/testResults.xml
 
   publish-test-results:
     name: Publish Test Results
     needs: test
     runs-on: ubuntu-latest
+    permissions:
+      checks: write
+      pull-requests: write
     if: ${{ !cancelled() }}
     steps:
       - uses: actions/download-artifact@v4

.gitignore

@@ -1 +1,4 @@
-nuget.exe
+nuget.exe
+Output/**
+Tests/Output/**
+Tests/out/**

.vscode/settings.json

@@ -3,5 +3,7 @@
     "powershell.codeFormatting.ignoreOneLineBlock": false,
     "powershell.codeFormatting.whitespaceAfterSeparator": false,
     "powershell.codeFormatting.whitespaceAroundOperator": false,
-    "powershell.codeFormatting.whitespaceBeforeOpenParen": false
-}
+    "powershell.codeFormatting.whitespaceBeforeOpenParen": false,
+    "powershell.codeFormatting.preset": "OTBS",
+    "powershell.codeFormatting.trimWhitespaceAroundPipe": true
+}

PSDepend/PSDepend.psd1

@@ -1,111 +1,111 @@
 @{
 
-# Script module or binary module file associated with this manifest.
-RootModule = 'PSDepend.psm1'
+    # Script module or binary module file associated with this manifest.
+    RootModule = 'PSDepend.psm1'
 
-# Version number of this module.
-ModuleVersion = '0.3.0'
+    # Version number of this module.
+    ModuleVersion = '0.3.0'
 
-# ID used to uniquely identify this module
-GUID = '63ea9e2a-320d-43ff-a11a-4930ca03cce6'
+    # ID used to uniquely identify this module
+    GUID = '63ea9e2a-320d-43ff-a11a-4930ca03cce6'
 
-# Author of this module
-Author = 'Warren Frame'
+    # Author of this module
+    Author = 'Warren Frame'
 
-# Company or vendor of this module
-#CompanyName = 'Unknown'
+    # Company or vendor of this module
+    #CompanyName = 'Unknown'
 
-# Copyright statement for this module
-Copyright = '(c) 2016 Warren F. All rights reserved.'
+    # Copyright statement for this module
+    Copyright = '(c) 2016 Warren F. All rights reserved.'
 
-# Description of the functionality provided by this module
-Description = 'PowerShell Dependency Handler'
+    # Description of the functionality provided by this module
+    Description = 'PowerShell Dependency Handler'
 
-# Minimum version of the Windows PowerShell engine required by this module
-PowerShellVersion = '3.0'
+    # Minimum version of the Windows PowerShell engine required by this module
+    PowerShellVersion = '3.0'
 
-# Name of the Windows PowerShell host required by this module
-# PowerShellHostName = ''
+    # Name of the Windows PowerShell host required by this module
+    # PowerShellHostName = ''
 
-# Minimum version of the Windows PowerShell host required by this module
-# PowerShellHostVersion = ''
+    # Minimum version of the Windows PowerShell host required by this module
+    # PowerShellHostVersion = ''
 
-# Minimum version of Microsoft .NET Framework required by this module
-# DotNetFrameworkVersion = ''
+    # Minimum version of Microsoft .NET Framework required by this module
+    # DotNetFrameworkVersion = ''
 
-# Minimum version of the common language runtime (CLR) required by this module
-# CLRVersion = ''
+    # Minimum version of the common language runtime (CLR) required by this module
+    # CLRVersion = ''
 
-# Processor architecture (None, X86, Amd64) required by this module
-# ProcessorArchitecture = ''
+    # Processor architecture (None, X86, Amd64) required by this module
+    # ProcessorArchitecture = ''
 
-# Modules that must be imported into the global environment prior to importing this module
-# RequiredModules = @()
+    # Modules that must be imported into the global environment prior to importing this module
+    # RequiredModules = @()
 
-# Assemblies that must be loaded prior to importing this module
-# RequiredAssemblies = @()
+    # Assemblies that must be loaded prior to importing this module
+    # RequiredAssemblies = @()
 
-# Script files (.ps1) that are run in the caller's environment prior to importing this module.
-# ScriptsToProcess = @()
+    # Script files (.ps1) that are run in the caller's environment prior to importing this module.
+    # ScriptsToProcess = @()
 
-# Type files (.ps1xml) to be loaded when importing this module
-# TypesToProcess = @()
+    # Type files (.ps1xml) to be loaded when importing this module
+    # TypesToProcess = @()
 
-# Format files (.ps1xml) to be loaded when importing this module
-FormatsToProcess = 'PSDepend.Format.ps1xml'
+    # Format files (.ps1xml) to be loaded when importing this module
+    FormatsToProcess = 'PSDepend.Format.ps1xml'
 
-# Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
-# NestedModules = @()
+    # Modules to import as nested modules of the module specified in RootModule/ModuleToProcess
+    # NestedModules = @()
 
-# Functions to export from this module
-FunctionsToExport = @('Get-Dependency','Get-PSDependScript','Get-PSDependType','Import-Dependency','Install-Dependency','Invoke-DependencyScript','Invoke-PSDepend','Test-Dependency')
+    # Functions to export from this module
+    FunctionsToExport = @('Get-Dependency','Get-PSDependScript','Get-PSDependType','Import-Dependency','Install-Dependency','Invoke-DependencyScript','Invoke-PSDepend','Test-Dependency')
 
-# Cmdlets to export from this module
-CmdletsToExport = '*'
+    # Cmdlets to export from this module
+    CmdletsToExport = '*'
 
-# Variables to export from this module
-# VariablesToExport = '*'
+    # Variables to export from this module
+    # VariablesToExport = '*'
 
-# Aliases to export from this module
-AliasesToExport = '*'
+    # Aliases to export from this module
+    AliasesToExport = '*'
 
-# DSC resources to export from this module
-# DscResourcesToExport = @()
+    # DSC resources to export from this module
+    # DscResourcesToExport = @()
 
-# List of all modules packaged with this module
-# ModuleList = @()
+    # List of all modules packaged with this module
+    # ModuleList = @()
 
-# List of all files packaged with this module
-# FileList = @()
+    # List of all files packaged with this module
+    # FileList = @()
 
-# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
-PrivateData = @{
+    # Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
+    PrivateData = @{
 
-    PSData = @{
+        PSData = @{
 
-        # Tags applied to this module. These help with module discovery in online galleries.
-         Tags = @('requirements', 'dependencies', 'dependency', 'manager', 'bundle', 'package')
+            # Tags applied to this module. These help with module discovery in online galleries.
+            Tags = @('requirements', 'dependencies', 'dependency', 'manager', 'bundle', 'package')
 
-        # A URL to the license for this module.
-         LicenseUri = 'https://github.com/RamblingCookieMonster/PSDepend/blob/master/LICENSE'
+            # A URL to the license for this module.
+            LicenseUri = 'https://github.com/PowerShellOrg/PSDepend/blob/master/LICENSE'
 
-        # A URL to the main website for this project.
-         ProjectUri = 'https://github.com/RamblingCookieMonster/PSDepend/'
+            # A URL to the main website for this project.
+            ProjectUri = 'https://github.com/PowerShellOrg/PSDepend/'
 
-        # A URL to an icon representing this module.
-        # IconUri = ''
+            # A URL to an icon representing this module.
+            # IconUri = ''
 
-        # ReleaseNotes of this module
-        ReleaseNotes = 'Added various PowerShell Core fixes thanks to @lipkau!'
+            # ReleaseNotes of this module
+            ReleaseNotes = 'Added various PowerShell Core fixes thanks to @lipkau!'
 
-    } # End of PSData hashtable
+        } # End of PSData hashtable
 
-} # End of PrivateData hashtable
+    } # End of PrivateData hashtable
 
-# HelpInfo URI of this module
-# HelpInfoURI = ''
+    # HelpInfo URI of this module
+    # HelpInfoURI = ''
 
-# Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
-# DefaultCommandPrefix = ''
+    # Default prefix for commands exported from this module. Override the default prefix using Import-Module -Prefix.
+    # DefaultCommandPrefix = ''
 
 }

PSDepend/Private/Get-ClonedObject.ps1

@@ -1,10 +1,41 @@
-# Idea from http://stackoverflow.com/questions/7468707/deep-copy-a-dictionary-hashtable-in-powershell 
-# borrowed from http://stackoverflow.com/questions/8982782/does-anyone-have-a-dependency-graph-and-topological-sorting-code-snippet-for-pow
 function Get-ClonedObject {
+    <#
+    .SYNOPSIS
+    Clones
+
+    .DESCRIPTION
+    Creates a deep copy of the provided object. This is useful for cloning
+    dependency objects before passing them to dependency scripts, allowing
+    modifications to the clone without affecting the original object.
+
+    .PARAMETER DeepCopyObject
+    The source object to copy from.
+
+    .EXAMPLE
+    Get-ClonedObject $MyObject
+
+    Get a deep copy of $MyObject.  This is used to clone dependency objects
+    before passing them to dependency scripts, so that we can modify the object
+    without affecting the original.
+
+    .NOTES
+    Idea from https://stackoverflow.com/a/7475744
+    borrowed from https://stackoverflow.com/q/8982782
+
+    BinaryFormatter was removed in .NET 7; use a recursive hashtable clone
+    instead
+    #>
     param($DeepCopyObject)
-    $memStream = new-object IO.MemoryStream
-    $formatter = new-object Runtime.Serialization.Formatters.Binary.BinaryFormatter
-    $formatter.Serialize($memStream,$DeepCopyObject)
-    $memStream.Position=0
-    $formatter.Deserialize($memStream)
+    $clone = @{}
+    foreach ($key in $DeepCopyObject.Keys) {
+        $val = $DeepCopyObject[$key]
+        if ($val -is [hashtable]) {
+            $clone[$key] = Get-ClonedObject $val
+        } elseif ($val -is [array]) {
+            $clone[$key] = $val.Clone()
+        } else {
+            $clone[$key] = $val
+        }
+    }
+    $clone
 }

PSDepend/Private/Test-PlatformSupport.ps1

@@ -1,18 +1,22 @@
 function Test-PlatformSupport {
-    [cmdletbinding()]
+    [CmdletBinding()]
     param(
         $Type,
-        [string[]]$Support
+        [string[]]
+        $Support
     )
 
     # test core/full
     if('Core' -eq $PSVersionTable.PSEdition) {
-        if($Support -notcontains 'core') {
+        # On Windows with PS Core, 'windows' in Support is sufficient (backwards compat with types
+        # declared before PS Core on Windows was common)
+        $windowsCoreOk = $IsWindows -and ($Support -contains 'windows')
+        if(-not $windowsCoreOk -and $Support -notcontains 'core') {
             Write-Verbose "Supported platforms [$Support] for type [$Type] does not contain [core].  Pull requests welcome!"
             return $false
         }
-    }
-    else { # full windows powershell
+    } else {
+        # full windows powershell
         if($Support -notcontains 'windows') {
             Write-Verbose "Supported platforms [$Support] for type [$Type] does not contain [windows].  Pull requests welcome!"
             return $false