fix: require safe Req versions#163
Merged
Merged
Conversation
|
Reviews (1): Last reviewed commit: "fix: require safe Req versions" | Re-trigger Greptile |
Contributor
posthog-elixir Compliance ReportDate: 2026-07-08 19:16:59 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
ioannisj
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Req has security fixes available in the 0.6 line:
The SDK dependency constraint still allowed affected Req releases. This tightens the minimum to
>= 0.6.1while preserving the previous< 1.0.0upper bound, so downstream projects resolve to a fixed Req version without narrowing future compatible 0.x releases unnecessarily.Also adds a patch Sampo changeset for the release notes.
💚 How did you test it?
mix deps.getmix testmix format --check-formattedmix compile --warnings-as-errors && mix posthog.public_api --checkmix credo --strictmix hex.build📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi made the scoped dependency metadata change and generated the Sampo changeset. A reviewer subagent checked the diff; based on that review, the lockfile was left unchanged because it already uses Req 0.6.1 and extra transitive dependency churn was unnecessary.