fix: Retry flags only on transport errors#155
Merged
Conversation
Contributor
posthog-elixir Compliance ReportDate: 2026-07-02 10:07:11 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
Reviews (1): Last reviewed commit: "fix: retry flags only on transport error..." | Re-trigger Greptile |
5 tasks
…y-20260628 # Conflicts: # test/posthog/api/client_test.exs
0afae4f to
3a6c66d
Compare
Member
Author
|
this will require PostHog/posthog-sdk-test-harness#30 to be merged/released |
|
Reviews (2): Last reviewed commit: "Merge branch 'main' into pi-flags-networ..." | Re-trigger Greptile |
ioannisj
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Align Elixir
/flags?v=2retry behavior with the other SDK fixes: retry only bounded network/transport/timeout failures, and do not retry HTTP/API status responses like 408, 429, or 5xx.This overrides Req's
:transientbehavior for/flagsso server responses are surfaced immediately while transient transport failures still get one retry by default.💚 How did you test it?
mix test test/posthog/api/client_test.exs test/posthog/config_test.exsmix test📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with pi.
/flagsnow uses a request-specific Req retry function that skips HTTP responses, retries transport exceptions, uses default max retries of 1 with0disabling retries, and applies exponential backoff starting at 300ms.