Use British spelling for UK LSR parameter paths#2829
Open
vahid-ahmadi wants to merge 1 commit intomainfrom
Open
Use British spelling for UK LSR parameter paths#2829vahid-ahmadi wants to merge 1 commit intomainfrom
vahid-ahmadi wants to merge 1 commit intomainfrom
Conversation
The UK labour supply response parameters are being renamed from gov.simulation.labor_supply_responses.* to gov.simulation.labour_supply_responses.* in PolicyEngine/policyengine-uk#1607. Update the two UK-only path strings in PolicyRightSidebar so the LSR sliders keep resolving after that merges. US paths unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PolicyRightSidebar’s UK behavioral response parameter paths to align with the upstream policyengine-uk rename from labor_supply_responses to labour_supply_responses, keeping the UK LSR toggle/sliders functional after the backend change.
Changes:
- Renamed two UK parameter path strings in
BehavioralResponseToggleto uselabour_supply_responses. - Added a changelog entry documenting the UK LSR path rename.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/policy/PolicyRightSidebar.jsx | Switches UK behavioral-response reform keys to labour_supply_responses.* so UK LSR toggles target the renamed parameters. |
| changelog_entry.yaml | Notes the UK LSR parameter path update for release tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+114
to
118
| "gov.simulation.labour_supply_responses.income_elasticity": { | ||
| [dateString]: -0.05, | ||
| }, | ||
| "gov.simulation.labor_supply_responses.substitution_elasticity": { | ||
| "gov.simulation.labour_supply_responses.substitution_elasticity": { | ||
| [dateString]: 0.25, |
vahid-ahmadi
added a commit
to PolicyEngine/policyengine-uk
that referenced
this pull request
Apr 20, 2026
Mirror the two consumed paths (`income_elasticity` and `substitution_elasticity`) under the renamed `labour_supply_responses` tree back to `gov.simulation.labor_supply_responses.*`, so the legacy policyengine-app PolicyRightSidebar (which hard-codes the old paths) keeps working between this PR landing and the matching app PR rebuilding against the new path. Removes the merge-window breakage that would otherwise hit the LSR sliders. Remove this alias in a follow-up release once consumers (the app PR PolicyEngine/policyengine-app#2829) have migrated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MaxGhenis
added a commit
to PolicyEngine/policyengine-uk
that referenced
this pull request
May 1, 2026
* Rename labor to labour in LSR parameters and variables Use British English spelling throughout the labour supply response module: directory names, file names, parameter labels, descriptions, import paths, and test references. Fixes #853. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove unrelated EASY_ISSUES file * Add deprecation alias for legacy labor_supply_responses paths Mirror the two consumed paths (`income_elasticity` and `substitution_elasticity`) under the renamed `labour_supply_responses` tree back to `gov.simulation.labor_supply_responses.*`, so the legacy policyengine-app PolicyRightSidebar (which hard-codes the old paths) keeps working between this PR landing and the matching app PR rebuilding against the new path. Removes the merge-window breakage that would otherwise hit the LSR sliders. Remove this alias in a follow-up release once consumers (the app PR PolicyEngine/policyengine-app#2829) have migrated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Map legacy LSR parameter changes --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Max Ghenis <mghenis@gmail.com>
Contributor
|
I reviewed this after merging PolicyEngine/policyengine-uk#1607. I am leaving the app PR unmerged for now because the frontend would start sending the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gov.simulation.labor_supply_responses.*→gov.simulation.labour_supply_responses.*in the UK repo.PolicyRightSidebar.jsx(income_elasticity,substitution_elasticity) so the LSR sliders keep resolving after the UK rename lands.elasticities.*) are untouched — those live inpolicyengine-usand aren't being renamed.Coordination
Merge order matters: this PR should land immediately before or after policyengine-uk#1607 to minimize the window where one side disagrees with the other. Safer sequence:
policyengine-ukin the app.Test plan
🤖 Generated with Claude Code