Separate App Engine deploy image build from push-time tests#3524
Merged
Separate App Engine deploy image build from push-time tests#3524
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3524 +/- ##
=======================================
Coverage 76.68% 76.68%
=======================================
Files 63 63
Lines 3444 3444
Branches 620 620
=======================================
Hits 2641 2641
Misses 629 629
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3523
Summary
.envsetup explicit instead of a side effect ofmake installDetails
make testfrom the App Engine Dockerfile build pathmake teston the GitHub runner insidedeploy-stagingbefore deploy.env.examplefrom actively setting a fakeGOOGLE_APPLICATION_CREDENTIALSpathValidation
bash -n .github/scripts/prepare_app_engine_bundle.sh .github/scripts/build_app_engine_image.sh .github/scripts/deploy_app_engine_version.sh .github/setup_env.sh