Fix: Route inbound Party endpoint messages to the correct socket during reconnect#96
Open
maryammadzadeh wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FPlayFabSocketSubsystem::GetSocket always returned the first active socket, with no guarantee that it matched the socket owned by the current net driver. This could cause inbound packets to be queued on the wrong socket, silently dropping them from the perspective of the active connection.
The proposal
GetSocket() now resolves the socket directly from the linked UPlayFabNetDriver, ensuring inbound packets always reach the socket the active net driver is reading from.
Fallback to newest active socket if no linked driver is available.
The net driver stores its exact socket when created.
FPlayFabSocketSubsystem::GetSocket first uses the linked net driver’s socket.
So inbound packets are enqueued on the same socket queue that UE handshake reads from.