Skip to content

fix: script image build - #63

Merged
Perry2004 merged 1 commit into
mainfrom
fix/script-image-build
Nov 1, 2025
Merged

Perry2004 merged 1 commit into
mainfrom
fix/script-image-build

Conversation

@Perry2004

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 1, 2025 22:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Docker build configuration for passing the AWS S3 bucket name environment variable. The issue was that the Docker build command was using an incorrect -e flag instead of --build-arg to pass build arguments to the Dockerfile.

  • Renamed the Dockerfile ARG from S3_BUCKET_NAME to AWS_S3_BUCKET_NAME for consistency
  • Corrected the docker buildx command to use --build-arg instead of -e flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/Dockerfile.script Renamed ARG from S3_BUCKET_NAME to AWS_S3_BUCKET_NAME
.github/workflows/build-lambda-image.yaml Fixed docker buildx command to use --build-arg instead of -e flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Perry2004
Perry2004 merged commit 474ed33 into main Nov 1, 2025
8 checks passed
@Perry2004
Perry2004 deleted the fix/script-image-build branch November 1, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants