Fix missing mods in Mind over Matter Breakdown#9839
Open
Squamto wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix missing mods in Mind over Matter Breakdown#9839Squamto wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Squamto wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
The breakdown for MoM sources did not include mods for specific damage types, except for lightning.
As you can see in the screenshots, the +36% was calculated correctly, but not shown in the mod list.
Steps taken to verify a working solution:
I added the respective Mods to the CalcSection. As far as I can tell, there are currently no sources of Cold-/Fire-MoM, but they are already respected in the calculations. It should not hurt to future-proof the UI as well.
The example Build is now working correctly.
Link to a build that showcases this PR:
Any build with Foulborn Mind of the Council. I used djfruchtzwerg#2457 NoMansHiero
Before screenshot:
After screenshot: