Add support for Flame Wall's Projectile Buff#1814
Open
Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Open
Add support for Flame Wall's Projectile Buff#1814Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding support for the projectile buff from Flame Wall, including the Lightning Infused portion. An issue I had to solve was enabling the buff regardless of which statSet is active, as the buff is now on a separate statSet "Projectile Damage" instead of rolled up into the same single set like in PoE 1. To do so, I've added a way to flag skills and use all buffs from other statSets, but I'm not super confident it's the cleanest way.
I'm also adding a conditionList for buffs so we can require multiple conditions at once. If there's already a way to do this without needing to add the condList, lemme know.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
obviously the wall isn't buffed as it isn't a projectile, but this shows the buff active even when "Projectile Damage" isn't the active statSet
