feat: Add paid trials support to price trial periods#154
Merged
Conversation
Introduce `PriceTrialPeriod` (a `Duration` subclass) with `requires_payment_method`, `unit_price`, and `unit_price_overrides` so trial periods can require an upfront/discounted charge, not just a free trial. Swaps `trial_period` typing from `Duration` to `PriceTrialPeriod` across Price/TransactionPreviewPrice entities, notification entities, and price-bearing request operations, and updates fixtures accordingly.
mikeymike
previously approved these changes
Jul 20, 2026
mikeymike
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
requires_payment_method,unit_price, andunit_price_overrideson pricetrial_period. See related changelogChanged
trial_periodfields are now typed asPriceTrialPeriod(subclass ofDuration, backwards compatible)