Update ITU parsing - #13
Merged
p1-mmr merged 1 commit intoSep 15, 2026
Merged
Conversation
P1-RCH
force-pushed
the
update-itu-parsing
branch
from
August 21, 2026 15:34
829e690 to
3bbf82a
Compare
P1-RCH
changed the base branch from
master
to
update-wikipedia-parsing-current-layout
August 21, 2026 15:35
P1-RCH
force-pushed
the
update-itu-parsing
branch
from
August 24, 2026 12:14
3bbf82a to
3f26da6
Compare
P1-RCH
force-pushed
the
update-itu-parsing
branch
from
August 25, 2026 13:59
3f26da6 to
c3f763d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ITU-T parsing/generation pipeline to use newer ITU annex baselines (SANC 1293 / SPC 1295) and adds recent ITU Operational Bulletin source text files into data/itut/.
Changes:
- Updated ITU MNC update parsing logic to buffer an operator line that can appear before the country/rule line in newer bulletin layouts.
- Switched SANC/SPC baselines to ITU OB 1293 (SANC) and 1295 (SPC), and updated downstream dataset generation/patching to use the new constants.
- Added multiple 2024–2026 ITU Operational Bulletin text files and updated the raw SANC dataset content.
Reviewed changes
Copilot reviewed 31 out of 64 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcc_mnc_genlib/scripts/parse_itut_bulletins.py | Updates MNC incremental parsing logic and bumps SANC/SPC baseline parsing to newer OBs. |
| src/mcc_mnc_genlib/scripts/gen_dataset.py | Documents merge strategy and switches dataset build to ITUT_SANC_1293 / ITUT_SPC_1295. |
| src/mcc_mnc_genlib/raw/itut_sanc_1293.json | Updates SANC country-name values and adds new entries present in the 1293 dataset. |
| src/mcc_mnc_genlib/core/patch_dataset.py | Loads/exports and patches the newer SANC/SPC raw datasets (1293/1295). |
| data/itut/T-SP-OB.1344-2026-OAS-PDF-E.txt | Adds ITU OB text source (2026) for local parsing/reference. |
| data/itut/T-SP-OB.1339-2026-OAS-PDF-E.txt | Adds ITU OB text source (2026) for local parsing/reference. |
| data/itut/T-SP-OB.1337-2026-OAS-PDF-E.txt | Adds ITU OB text source (2026) for local parsing/reference. |
| data/itut/T-SP-OB.1332-2026-OAS-PDF-E.txt | Adds ITU OB text source (2026) for local parsing/reference. |
| data/itut/T-SP-OB.1329-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1328-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1326-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1324-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1311-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1308-2025-OAS-PDF-E.txt | Adds ITU OB text source (2025) for local parsing/reference. |
| data/itut/T-SP-OB.1306-2024-OAS-PDF-E.txt | Adds ITU OB text source (2024) for local parsing/reference. |
| data/itut/T-SP-OB.1302-2024-OAS-PDF-E.txt | Adds ITU OB text source (2024) for local parsing/reference. |
| data/itut/T-SP-OB.1300-2024-OAS-PDF-E.txt | Adds ITU OB text source (2024) for local parsing/reference. |
| data/itut/T-SP-OB.1298-2024-OAS-PDF-E.txt | Adds ITU OB text source (2024) for local parsing/reference. |
| data/itut/T-SP-OB.1296-2024-OAS-PDF-E.txt | Adds ITU OB text source (2024) for local parsing/reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+567
to
+571
| if not (cntr and rule): | ||
| # MNO before rule is found - buffer it for the upcoming rule+MNC line | ||
| pre_rule_mno = m.group(1).strip() | ||
| mnc_empt = False | ||
| continue |
| @@ -904,15 +918,15 @@ def main(): | |||
| print('> error occured during MNC extraction: %r' % err) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.