fix(vstopei): fix guest IntFile selection when writing to vsClaim - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes VS guest interrupt-file selection during vsClaim handling by ensuring the claim signal only applies to the currently selected guest (based on vgein), preventing unintended claiming/clearing in other guest IntFiles.
Changes:
- Remove
vgeinfrom the per-IntFileCSR input bundle and derive guest selection externally. - Gate
IntFile.fromCSR.claimfor VS privilege so only the selected guest IntFile receives the claim. - Minor whitespace/formatting cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -410,11 +409,8 @@ class IMSIC( | |||
|
|
|||
| val intFile = Module(new IntFile) | |||
| // Preventing overflow | |||
zhaohong1988
approved these changes
Jul 29, 2026
zhaohong1988
left a comment
zhaohong1988
left a comment
Contributor
There was a problem hiding this comment.
Good to fix the issue
upsetgrass
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.