Preserve cylindrical tank volumes in EN_settankdata - #934
Merged
LRossman merged 1 commit intoAug 25, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN_settankdata() currently reconstructs cylindrical tank volumes through
the internal-unit tankvolume() path. This uses a different floating-point
operation order than the INP parser when constructing the same tank.
As a result, reapplying identical tank data through the Toolkit can change
the internally stored tank volumes by a very small amount. In event-driven
hydraulic simulations this can alter the ordering of otherwise simultaneous
tank events and lead to different downstream results.
This change computes cylindrical tank volumes in user units before
converting them to internal units, matching the arithmetic path used by the
INP parser.
A regression test verifies that reapplying identical EN_settankdata()
parameters preserves the initial, minimum, and maximum tank volumes
bit-for-bit.