Allow negative bulk and tank reaction orders in EN_setoption - #933
Merged
LRossman merged 1 commit intoAug 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN_setoption() currently rejects all negative option values before
handling the individual option type. This prevents setting negative
EN_BULKORDER and EN_TANKORDER values through the Toolkit API.
Negative bulk and tank reaction orders are already accepted by the INP
parser and supported by the quality solver as Michaelis-Menten kinetics.
This change allows negative values for EN_BULKORDER and EN_TANKORDER
while preserving the existing validation for other options, including
EN_WALLORDER.
A regression test verifies that negative bulk and tank orders can be set
and retrieved through the Toolkit and used successfully in a quality
analysis.