Avoid Black Frames (Adding a new clip - and it does not appear)#1077
Merged
Conversation
- Invalidate affected final_cache frames in AddClip() - Remove duplicate JSON insert invalidation - Add regression test for stale black frames
- Only mark timeline clips as open after Clip::Open() succeeds - Allow later GetFrame() calls to retry opening clips after transient failures - Prevent cache rebuilds from repeatedly generating blank frames for closed clips - Add regression coverage for a failed first open followed by a successful retry
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.