Skip to content

[com1DFA] Add TJEM entrainment model - #1339

Open
Michael-Pallua wants to merge 8 commits into
masterfrom
MP_com1DFA_addTJEM
Open

Michael-Pallua wants to merge 8 commits into
masterfrom
MP_com1DFA_addTJEM

Conversation

@Michael-Pallua

Copy link
Copy Markdown
Contributor

The goal is to make the TJEM entrainment model, which is already present in com9MoTVoellmy, available in com1DFA.

Short description of changed files:

  • com1DFACfg.ini:
    A parameter to select the desired entrainment model (etnrType) is included as well as the parameter of the new entrainment model: the shear strength of the erodible snow cover (entShearStrength).

  • com1DFA.py:
    Changes are made to implement the new selection between the two now available entrainment models.

  • DFAfunctionsCython.pyx and DFAfunctionsCython.pxd
    A new function, computeEntMassAndForceTjem(), which implements the equations of the TJEM entrainment model is added.

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@Michael-Pallua Michael-Pallua self-assigned this Sep 25, 2026
@Michael-Pallua Michael-Pallua added the enhancement New feature or request label Sep 25, 2026
@qltysh

qltysh Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

All good ✅

Comment thread avaframe/com1DFA/com1DFA.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant