uclibc-compat: fix __aeabi_d2iz infinite recursion#2002
Merged
Conversation
GCC converts `(int)x` (double-to-int cast) into a call to __aeabi_d2iz, which is the function itself — causing infinite recursion and a stack overflow. Found via AddressSanitizer on hi3516cv100 hardware. Replace with manual IEEE 754 double field extraction that uses only integer operations, breaking the recursion. Ref: #1992 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
__aeabi_d2izinlibuclibc-compat.socaused a stack overflow (infinite recursion). GCC converts(int)xto a call to__aeabi_d2iz— which is the function itself.Found via AddressSanitizer on hi3516cv100 hardware (128MB RAM, osmem=96M for ASAN headroom):
Disassembly confirmed the recursion:
Fix
Replace with manual IEEE 754 double field extraction using only integer operations.
Test plan
hisi_free_mem_ex(was crashing here)Ref: #1992