FIX-292: Finish deferred unmapping before empty-cycle recovery - #1775
Open
peter-lawrey wants to merge 6 commits into
Open
peter-lawrey wants to merge 6 commits into
peter-lawrey wants to merge 6 commits into
Conversation
…2-release-cycle-before-recovery
…2-release-cycle-before-recovery
…2-release-cycle-before-recovery
…2-release-cycle-before-recovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty-cycle recovery closes its mapped bytes and removes the cache entry, then renames the unusable segment. Those releases can be deferred, so Windows can reject the rename while this process still owns the mapping. Drain pending releases before attempting that recovery rename; retain the existing read-only handling and header timeout.
A subprocess regression leaves background releases queued and runs the existing empty-cycle append/readback scenario. It owns and bounds the child process, preserves the data assertions, and requires the recovery warning. Existing coverage still exercises a segment locked by another process.
Stacked on #1774, which includes the fixture cleanup from #1770. The recovery delta is kept separate from the partial directory-binding repair.