QUEUE-148: address follow-up table-store review - #1753
Draft
peter-lawrey wants to merge 1 commit into
Draft
peter-lawrey wants to merge 1 commit into
peter-lawrey wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire format policy
BINARY_LIGHT is the supported table-store encoding. BINARY remains a legacy selector for the common subset and is decoded with BINARY_LIGHT. READ_ANY is read-only detection only. RAW, fieldless, compressed, and text formats remain unsupported.
Security-focused concerns are explicitly outside this follow-up scope.
Mac build 1828
The supplied log built commit 2309982, not this branch. Its two remediation-test failures were global resource-tracing collisions with a concurrently running test and both passed on rerun. The broader failures were timeouts, disk use, and leaked resources across unrelated tests. The log contains no tryLock IOException evidence, so generic acquisition IOException remains terminal pending supported-platform evidence.
Verification
Deliberately deferred