Skip to content

SUPERSEDED: QUEUE-144 Queue context listener core - #1720

Closed
peter-lawrey wants to merge 1 commit into
feature/QUEUE-144-queue-appender-eof-prereqfrom
feature/QUEUE-144-queue-context-listener-core
Closed

peter-lawrey wants to merge 1 commit into
feature/QUEUE-144-queue-appender-eof-prereqfrom
feature/QUEUE-144-queue-context-listener-core

Conversation

@peter-lawrey

@peter-lawrey peter-lawrey commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Important

Superseded: do not merge this PR.

The current replacement is #1725, based on the minimal QUEUE-143 Queue integration branch from #1724.

Why this PR cannot simply be retargeted

This branch is descended from the obsolete appender prerequisite #1719, which was itself based on the old full feature/QUEUE-143-RollFileCleanupMain branch. Retargeting this head to the new QUEUE-143 integration branch would make removed cleanup implementation appear in the merge diff.

PR #1725 reapplies the context-listener core patch and merges feature/QUEUE-143-queue-integration-points. Its configured base is an ancestor of its head, and its merge diff is limited to the intended eleven Queue context-listener core files.

Review findings carried to the replacement stack

  • The core patch still says the supplied method writer is callback-scoped and implements that restriction. This conflicts with the final Wire contract, under which the writer may be retained for normal use.
  • Listener failure before writing currently retries in the same roll context, while the Wire contract says a failed notification is not retried for that context.
  • This core layer adds roughly 1,000 lines of production behaviour but its only test class injects a recording lifecycle. The black-box roll, persistence, failure and ownership tests are deferred to #1726. At least a minimal successful-write/once-per-roll test should accompany the core change, or QUEUE-144: Legacy listener source; deliver through #1746 [do not merge] #1725 and Superseded: QUEUE-144 context listener fixtures #1726 must be reviewed and merged as one behavioural unit.

Review and merge should continue on #1725 after those contract differences are reconciled.

Copy link
Copy Markdown
Member Author

Superseded by the split-base QUEUE-144 stack. Use #1725 instead; it is based on the new minimal QUEUE-143 Queue integration PR (#1724) and does not include the moved roll cleanup implementation.

@peter-lawrey peter-lawrey changed the title QUEUE-144: Add queue context listener core SUPERSEDED: QUEUE-144 Queue context listener core Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant