fix(storage): make SQLite message writes atomic - #172
Merged
Conversation
Fixes #171. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Val Alexander <bunsthedev@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR addresses SQLite storage consistency by making SqliteSessionStore::save_message atomic: the message insert and the session metadata update happen in a single transaction, preserving idempotency for duplicate message UUIDs and adding regression tests for rollback/retry behavior.
Changes:
- Wrap
messagesinsertion and conditionalsessionsmetadata updates in a single SQLite transaction. - Preserve idempotency by only updating
sessions.updated_at/message_countwhen a message row is newly inserted. - Add SQLite regression tests covering rollback on failure and duplicate message IDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
88
to
92
| if inserted > 0 { | ||
| self.conn.execute( | ||
| transaction.execute( | ||
| "UPDATE sessions | ||
| SET updated_at = ?1, | ||
| message_count = message_count + 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo test -p claurst-core sqlite_storage::testscargo test -p claurst-corecargo check --workspacecargo clippy --workspace --all-targets -- -D warningscargo fmt --all --checkFixes #171