Conversation
|
Thanks for the PR @babs. Could you explain what features the rotary command plugin provides over OpenDeck's built-in support for rotation in the Run Command action, and what features the rotary volume plugin provides over the existing https://marketplace.tacto.live/plugin/com.sfgrimes.pipewire-audio plugin? |
|
I started with the later to customize the on press action (long press). Might be interesting to have indicators for rotary compatible actions ? [there is also a pinch of curiosity on how to make plugins :)] |
|
And the why about audio rotary is that on my machine, the node's com.sfgrimes.pipewire-audio version consume 20-30% of a core. |
|
I see, thanks. @Terrorwolf01 could you give these plugins a try on your SD+ so we can test they work on multiple systems? |
|
Hi, |
|
Yeah, actually, that's right - @sfgrimes had pushed v1.1.0 of the audio plugin that dramatically reduced the CPU usage when using the knobs to change volume, so maybe this rotary audio plugin isn't necessary? |
|
It was not only when using the knob it was constant :/ |
|
Seems to be waaaay better |
|
Hi, |
If the rotary volume plugin is no longer necessary, please drop it from the PR :) |
851543f to
6d64194
Compare
|
@nekename done :) |
|
@babs just looked at your function, and it's going to have problems - for example, in Flatpak and Distrobox sandboxes. Could I ask you to take the logic from OpenDeck's Run Command action, which handles Flatpak, Distrobox and Windows logic, and also to add macOS and Windows builds to your GitHub action so that the plugin can be used cross-platform? I don't see any platform-specific logic so you'd just need to add them to the build matrix. That way, the command execution behaviour is consistent with the existing action. |
Summary
info.degois.damien.opendeck.plugins.rotary-command: run custom shell commands on rotary encoder actions (CW, CCW, press, long press)info.degois.damien.opendeck.plugins.rotary-volume: control audio volume and mute via rotary encoder using PipeWire/PulseAudioNote
Both icons are currently identical (same rotary knob SVG). The volume plugin icon will be updated in a follow-up.