Skip to content

feat(stratus): add credential reference element on contracts (#7850) - #454

Merged
Gabriel Pezé (gabriel-peze) merged 2 commits into
mainfrom
isse/7850-add-credential-reference-to-contract
Oct 2, 2026
Merged

Gabriel Pezé (gabriel-peze) merged 2 commits into
mainfrom
isse/7850-add-credential-reference-to-contract

Conversation

@gabriel-peze

@gabriel-peze Gabriel Pezé (gabriel-peze) commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

  • Add to the stratus contracts the credencial reference field

Testing Instructions

  1. Run the stratus injector
  2. generated contracts should include a credential reference fields

Related issues

/!\ Do not merge before this PR /!\

Copilot AI lite review requested due to automatic review settings September 17, 2026 12:42
@gabriel-peze Gabriel Pezé (gabriel-peze) added the filigran team Item from the Filigran team. label Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #454   +/-   ##
=======================================
  Coverage   81.58%   81.59%           
=======================================
  Files         153      153           
  Lines        6028     6030    +2     
=======================================
+ Hits         4918     4920    +2     
  Misses       1110     1110           
Files with missing lines Coverage Δ
stratus/stratus/contracts/__init__.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The referenced credential API is unavailable in the pinned/runtime dependency, causing imports to fail before tests or the injector run.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds credential-reference fields to Stratus contracts with regression coverage.

Changes:

  • Adds credential-reference elements to generated contracts.
  • Tests field properties, ordering, and platform mappings.
File summaries
File Summary
stratus/test/test_contracts.py Tests credential-reference contract behavior.
stratus/stratus/contracts/__init__.py Adds credential-reference fields during contract generation.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

SupportedLanguage,
prepare_contracts,
)
from pyoaev.credential.utils import build_single_referenced_credential_element

@Megafredo Frédéric BASLER (Megafredo) left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! It's ok for me ;)
We'll need to rebase once the PR on the Client-Python is merged.

@gabriel-peze
Gabriel Pezé (gabriel-peze) force-pushed the isse/7850-add-credential-reference-to-contract branch from 7589603 to b8ae375 Compare October 2, 2026 11:22
@gabriel-peze
Gabriel Pezé (gabriel-peze) merged commit aee68a0 into main Oct 2, 2026
47 checks passed
@gabriel-peze
Gabriel Pezé (gabriel-peze) deleted the isse/7850-add-credential-reference-to-contract branch October 2, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(stratus): add credential reference element on contracts

3 participants