Skip to content

Raster to vector Conversion#434

Open
PondiB wants to merge 17 commits into
draftfrom
raster-to-vector
Open

Raster to vector Conversion#434
PondiB wants to merge 17 commits into
draftfrom
raster-to-vector

Conversation

@PondiB

@PondiB PondiB commented Apr 25, 2023

Copy link
Copy Markdown
Member

closes issue #155

An optional "projection" parameter has been inspired by the Rasterio function and GEE. Not sure if we should keep it.

@PondiB PondiB requested review from m-mohr and soxofaan April 25, 2023 09:47
@PondiB

PondiB commented Apr 25, 2023

Copy link
Copy Markdown
Member Author

FYI; I'll try and figure out what causes the failures.

@m-mohr

m-mohr commented Apr 25, 2023

Copy link
Copy Markdown
Member

@PondiB experimental: true is missing, remove dot at the end of summary and a spellcheck issue :-)

@PondiB

PondiB commented Apr 25, 2023

Copy link
Copy Markdown
Member Author

@PondiB experimental: true is missing, remove dot at the end of summary and a spellcheck issue :-)

Aha, awesome, thanks @m-mohr

@soxofaan soxofaan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json
PondiB and others added 3 commits April 28, 2023 14:51
Co-authored-by: Stefaan Lippens <soxofaan@users.noreply.github.com>
@m-mohr m-mohr added this to the 2.1.0 milestone Apr 29, 2023
Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json Outdated
Comment thread proposals/raster_to_vector.json Outdated

@m-mohr m-mohr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be testable, this needs more specific information about how the conversion is done. See comments above.

PondiB and others added 2 commits December 13, 2023 22:29
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@PondiB

PondiB commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

To be testable, this needs more specific information about how the conversion is done. See comments above.

Factored that in.

@PondiB PondiB closed this Dec 14, 2023
@PondiB PondiB reopened this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants