OVM deposit() refactor#199
Merged
Merged
Conversation
nickh-obol
approved these changes
Jun 12, 2026
pinebit
added a commit
that referenced
this pull request
Jun 18, 2026
The revert of #199 also dropped the forge-std submodule from v1.9.6 back to v1.5.6. Keep the v1.9.6 pin so the test suite continues to build and pass; only the OVM deposit() refactor is reverted by this PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nickh-obol
pushed a commit
that referenced
this pull request
Jun 18, 2026
* Revert "OVM deposit() refactor (#199)" This reverts commit 3458e14. * Restore forge-std to v1.9.6 pin The revert of #199 also dropped the forge-std submodule from v1.9.6 back to v1.5.6. Keep the v1.9.6 pin so the test suite continues to build and pass; only the OVM deposit() refactor is reverted by this PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved
OVM.deposit()behavior by validatingwithdrawal_credentials.Details
NA
How to test it
ticket: none