feerecipient: document hardened sign and fetch behavior#159
Merged
Conversation
5 tasks
…and signature verification
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
OisinKyne
force-pushed
the
pinebit/feerecipient-fix
branch
from
July 2, 2026 15:50
fa0fdd0 to
fec21b4
Compare
OisinKyne
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feerecipient fetchmerges newly fetched registrations into the existing overrides file (keeping the latest timestamp per validator) instead of overwriting it, and that unrelated validators' entries are preserved. A fetched registration that is not newer than the existing override is discarded with a warning.feerecipient signvalidation: the fee recipient must not be the zero address, a mixed-case address must match its EIP-55 checksum, and a manually supplied--timestampmust be later than the registration that currently has quorum on the remote API (the command rejects it otherwise). When joining an in-progress registration, its timestamp and gas limit are adopted with a warning if explicit flags are overridden.Charon PR: ObolNetwork/charon#4571