Skip to content

feerecipient: document hardened sign and fetch behavior#159

Merged
OisinKyne merged 2 commits into
mainfrom
pinebit/feerecipient-fix
Jul 2, 2026
Merged

feerecipient: document hardened sign and fetch behavior#159
OisinKyne merged 2 commits into
mainfrom
pinebit/feerecipient-fix

Conversation

@pinebit

@pinebit pinebit commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document that feerecipient fetch merges newly fetched registrations into the existing overrides file (keeping the latest timestamp per validator) instead of overwriting it, and that unrelated validators' entries are preserved. A fetched registration that is not newer than the existing override is discarded with a warning.
  • Document that a fetch with insufficient quorum logs and returns without touching the overrides file, rather than erroring.
  • Document that fetched registrations are signature-verified, and that a registration failing verification is skipped and logged while the rest of the batch is still merged and written.
  • Document that a corrupt or invalid overrides file does not block fetching (it is rebuilt), and that the file is written atomically.
  • Document feerecipient sign validation: the fee recipient must not be the zero address, a mixed-case address must match its EIP-55 checksum, and a manually supplied --timestamp must be later than the registration that currently has quorum on the remote API (the command rejects it otherwise). When joining an in-progress registration, its timestamp and gas limit are adopted with a warning if explicit flags are overridden.
  • Document that the default gas limit is resolved from the most recent of the cluster lock, the overrides file, and the current quorum registration on the remote API.
  • Add guidance for troubleshooting a validator that still shows its previous fee recipient after fetching.

Charon PR: ObolNetwork/charon#4571

@pinebit pinebit changed the title feerecipient: update fetch behavior for merge, quorum, and sig verification feerecipient: document hardened sign and fetch behavior Jul 2, 2026
@pinebit
pinebit requested review from KaloyanTanev and OisinKyne July 2, 2026 15:11
pinebit and others added 2 commits July 2, 2026 17:50
@OisinKyne
OisinKyne force-pushed the pinebit/feerecipient-fix branch from fa0fdd0 to fec21b4 Compare July 2, 2026 15:50
@OisinKyne
OisinKyne merged commit 5ec4db2 into main Jul 2, 2026
2 checks passed
@OisinKyne
OisinKyne deleted the pinebit/feerecipient-fix branch July 2, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants