Skip to content

Tags pagination - #722

Closed
atif09 wants to merge 2 commits into
OWASP:mainfrom
atif09:tags-pagination
Closed

Tags pagination#722
atif09 wants to merge 2 commits into
OWASP:mainfrom
atif09:tags-pagination

Conversation

@atif09

@atif09 atif09 commented Jan 17, 2026

Copy link
Copy Markdown

Summary

This PR adds pagination support to the /rest/v1/tags endpoint to handle large result sets efficiently.

Details

  • Added get_by_tags_with_pagination() method to database layer
  • Updated /rest/v1/tags endpoint to accept page and items_per_page query parameters
  • Returns total_pages and page in JSON response
  • Maintains backward compatibility (works without pagination parameters)
  • Added comprehensive tests for pagination logic

Why this change

The /rest/v1/tags endpoint had a TODO comment indicating pagination was needed. Without pagination, queries with many tags could return large result sets, causing performance issues and poor UX. This change enables efficient data retrieval with client-controlled page sizes.

Scope

@northdpole

Copy link
Copy Markdown
Collaborator

please sign your commits so we can review this pr

@atif09

atif09 commented Jan 25, 2026

Copy link
Copy Markdown
Author

ive signed the commits 👍🏼

please sign your commits so we can review this pr

@northdpole

Copy link
Copy Markdown
Collaborator

Thank you! Tags pagination is covered by the broader #760 (tags + text_search). Closing as superseded.

@northdpole northdpole closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make pagination also for tag results

2 participants