Open
Conversation
midgemacf
reviewed
Apr 22, 2026
| ) | ||
|
|
||
| def __init__(self, input_file: str): | ||
| def __init__(self, input_file: str | Path, chunk_size: int | None = None, **kwargs: dict): |
Contributor
There was a problem hiding this comment.
I think ruff got rid of my kwargs somewhere along the way? Or it's something coming from a different merge... Either way the same issue affects all the other probes too. good catch, I can push a fix for the rest to this branch (or just straight to my OG one)
| "psycopg2-binary>=2.9.0,<3", | ||
| "python-dotenv", | ||
| "python-multipart>=0.0.20,<0.0.21", | ||
| "python-multipart>=0.0.26,<0.0.27", |
Contributor
There was a problem hiding this comment.
we'll have to make sure backend still works with this bumped
midgemacf
reviewed
Apr 22, 2026
| def generate_api_key(expire_after: Optional[int] = None, session: Session = Depends(get_db)): | ||
| def generate_api_key( | ||
| expire_after: Optional[int] = None, | ||
| api_key: str = Depends(validate_api_key_or_allow_bootstrap), |
Contributor
There was a problem hiding this comment.
Wouldn't this be "None" if there are no keys, and fail?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.