Skip to content

Cell Edge Results: disable by default, skip loading when inactive - #14523

Merged
magnesj merged 2 commits into
devfrom
copilot/fix-cell-edge-results-loading-again
Aug 13, 2026
Merged

Cell Edge Results: disable by default, skip loading when inactive#14523
magnesj merged 2 commits into
devfrom
copilot/fix-cell-edge-results-loading-again

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Cell Edge Results eagerly loaded all static results matching the cell-edge base name (MULTNUM, MULTX/X-/Y/Y-/Z/Z-) even when the feature was disabled, wasting I/O and memory on every view load.

Changes

  • RimCellEdgeColors.cpp: Changed m_enableCellEdgeColors default from truefalse
  • RimCellEdgeColors::loadResult(): Added early-out when disabled — no results are fetched until the user explicitly enables Cell Edge Results
void RimCellEdgeColors::loadResult()
{
    if ( !m_enableCellEdgeColors() ) return;   // <-- new guard
    if ( !m_reservoirView->currentGridCellResults() ) return;
    // ...
}

The existing setActive(false) call in RimEclipseViewCollection remains as explicit documentation of intent, and is now consistent with the new default.

Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix loading of Cell Edge Results when disabled Cell Edge Results: disable by default, skip loading when inactive Aug 13, 2026
Copilot AI requested a review from magnesj August 13, 2026 12:52

@jorgenherje jorgenherje left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good.

@magnesj
magnesj marked this pull request as ready for review August 13, 2026 13:37
@magnesj
magnesj merged commit 2a0f9a3 into dev Aug 13, 2026
19 checks passed
@magnesj
magnesj deleted the copilot/fix-cell-edge-results-loading-again branch August 13, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Cell Edge Results loaded even if disabled

3 participants