Cell Edge Results: disable by default, skip loading when inactive - #14523
Merged
Conversation
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix loading of Cell Edge Results when disabled
Cell Edge Results: disable by default, skip loading when inactive
Aug 13, 2026
jorgenherje
approved these changes
Aug 13, 2026
jorgenherje
left a comment
Collaborator
There was a problem hiding this comment.
Tested and looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cell Edge Results eagerly loaded all static results matching the cell-edge base name (MULTNUM, MULTX/X-/Y/Y-/Z/Z-) even when the feature was disabled, wasting I/O and memory on every view load.
Changes
RimCellEdgeColors.cpp: Changedm_enableCellEdgeColorsdefault fromtrue→falseRimCellEdgeColors::loadResult(): Added early-out when disabled — no results are fetched until the user explicitly enables Cell Edge ResultsThe existing
setActive(false)call inRimEclipseViewCollectionremains as explicit documentation of intent, and is now consistent with the new default.