Fix active link highlight clashing#266
Open
jondewijones wants to merge 1 commit into
Open
Conversation
…would trigger migration and vice versa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix active link highlighting where
/data-admin/series/migration-1url would trigger Migration menu item to be highlights, and vice versa when "series" was included in a migration URLHow to review
Test by going to a page like
/data-admin/series/migration-1(doesn't matter if it doesn't exist) and see that Migration is highlighted. Pull code and then see that "Dataset catalogue" is selected as it should beWho can review
Anyone