fix Spotify <iframe> embed overflows on notion two-column layout#709
Open
offab wants to merge 2 commits into
Open
fix Spotify <iframe> embed overflows on notion two-column layout#709offab wants to merge 2 commits into
offab wants to merge 2 commits into
Conversation
|
@offab is attempting to deploy a commit to the Saasify Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, embed containers (such as Spotify <iframe> embeds) suffer from overflow issues because their width is hardcoded to 600px. This causes the embed to break out of its parent container when placed in constrained spaces, such as within a narrow two-column layout.
Solution
Updated the CSS for .notion-asset-wrapper-embed > div to use fluid width constraints, the embed wrapper now scales dynamically and properly respects the boundaries of its parent container.
Update iframe background to transparent to prevent white corners on rounded edges in dark mode
Before
After
