#3944 filtering reimbursements by project#4156
Open
Conversation
added 3 commits
April 14, 2026 22:30
…cing/FinishLine into #3944-filter-reimbursements-by-project merge
Contributor
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
filtering is perfect, this looks so good! last thing - in reimbursementrequestinfo could we add project to the search bar filtering as well
added 2 commits
April 16, 2026 18:08
…cing/FinishLine into #3944-filter-reimbursements-by-project merge
wavehassman
requested changes
Apr 18, 2026
| isLoading: allProjectsIsLoading, | ||
| isError: allProjectsIsError, | ||
| error: allProjectsError | ||
| } = useAllProjects(); |
Contributor
There was a problem hiding this comment.
add the error check with the others
| /> | ||
| {allProjectsIsLoading ? ( | ||
| <LoadingIndicator /> | ||
| ) : allProjectsIsError ? ( |
Contributor
There was a problem hiding this comment.
add the error check and loading check with the other error checks
|
|
||
| const matchesProject = request.reimbursementProducts.some((product) => { | ||
| const reason = product.reimbursementProductReason; | ||
| if ((reason as WBSElementData).wbsNum) { |
Contributor
There was a problem hiding this comment.
use a type guard instead of casting like this:
if ('wbsNum' in reason) {
reason.wbsNum
reason.wbsName
}
this should remove all as WbsElementData calls
added 2 commits
April 20, 2026 19:07
…cing/FinishLine into #3944-filter-reimbursements-by-project merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a Filter by Project section to the Reimbursement requests filter sidebar
Screenshots
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3944