Mute fusion warnings#80
Open
maritsandstad wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces log verbosity during patch termination/fusion by gating a particularly verbose fusion warning behind the module’s debug flag.
Changes:
- Wrap the “small nocomp patch … relabelling and fusing into the largest patch …” warning in a
debugconditional to suppress it in non-debug builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3622
to
+3631
| if(debug) then | ||
| warn_msg = 'small nocomp patch wasnt able to find a matching patch to '// & | ||
| 'fuse with; relabelling and fusing into the largest patch of '// & | ||
| 'the same land-use label. '// & | ||
| 'nocomp pft: '//trim(I2S(currentPatch%nocomp_pft_label))// & | ||
| 'lu label: '//trim(I2S(currentPatch%land_use_label))// & | ||
| 'area: '//trim(N2S(currentPatch%area)) | ||
| call FatesWarn(warn_msg,index=5) | ||
|
|
||
|
|
||
| call FatesWarn(warn_msg,index=5) | ||
| end if |
| if ( associated(largest_patch) ) then | ||
| warn_msg = 'small nocomp patch wasnt able to find a matching patch to '// & | ||
| if(debug) then | ||
| warn_msg = 'small nocomp patch wasnt able to find a matching patch to '// & |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Putting very arduous logging messages from patch fusion below debug statment to not overfill logs
Collaborators:
@kjetilaas
Expectation of Answer Changes:
Just slightly shorter logs
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: