noresm3_0_040_cam6_4_121: Refactor and enhance CMIP7 namelist process#287
Merged
Conversation
- Implement configuration file for usermods sets - Add support for output with COSP and/or Aerocom fields - Add support for separate CAM field request (added to CMIP7 request) - Rewrote README.md file - Add regression test for full output (modify base NHIST test)
gold2718
requested review from
DirkOlivie,
MichaelSchulzMETNO,
Ovewh and
oyvindseland
Ovewh
reviewed
Jun 25, 2026
gold2718
commented
Jun 25, 2026
| missing7 = check_for_missing_fieldnames(all_fieldnames, cmip7_request, | ||
| "CMIP7") | ||
| cam_request = parse_spreadsheet(camfile) | ||
| missingc = check_for_missing_fieldnames(all_fieldnames, cmip7_request, |
Author
There was a problem hiding this comment.
Thanks. I also found that this morning since RESTOM and CO2 were not reported as missing.
Ovewh
reviewed
Jun 25, 2026
| print(f" {field}") | ||
| # end for | ||
| arglist = command_line(sys.argv[1:]) | ||
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline = arglist |
Collaborator
There was a problem hiding this comment.
Suggested change
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline = arglist | |
| cmipfile, camfile, usermods, configfile, overwrite, error, maxline,ignore_fieldlist = arglist |
Ovewh
reviewed
Jun 25, 2026
added 3 commits
July 1, 2026 20:27
- Improve extract_master_list.py to allow multiple input logs plus user-defined output file. - Create fixed list for CAM fields that do not have addfld calls. These fields are available but are not added to any fincl as their output is hard coded. - Create set of fields for emission-driven runs - Use chemistry diags for a specific package, not from master list - Parse history handling flags from spreadsheets (e.g., CMIP7 data request) - Update PUMAS tag with NCAL bug fix
Rename 'Max' usermods to 'Cosp' Improve reporting of missing fields (introduce verbose option)
- Add docosp = .true. for COSP usermods runs
Author
|
I think this is ready for final review for someone. I have included a test script that does a 1-month run for each usermod in this PR. These runs are currently at: Note, I have a few missing fields that need some code and there are other missing fields (see #286), however, I think this code should go in now to facilitate working on the CMIP7 data-processing workflow. |
20 tasks
mvertens
approved these changes
Jul 3, 2026
gold2718
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Refactor and enhance CMIP7 namelist process
Contributors: gold2718
Reviewers: @oyvindseland, @DirkOlivie, @Ovewh, @MichaelSchulzMETNO
Purpose of changes: #286
Github PR URL: #287
Changes made to build system: None
Changes made to the namelist: None except for new usermods options
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
Detailed description of changes
Testing:
addresses: #286