Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix bare except blocks swallowing system signals#24

Open
NoWon1 wants to merge 1 commit into
mainfrom
sentinel/fix-bare-excepts-5542737121129061686
Open

πŸ›‘οΈ Sentinel: [CRITICAL/HIGH] Fix bare except blocks swallowing system signals#24
NoWon1 wants to merge 1 commit into
mainfrom
sentinel/fix-bare-excepts-5542737121129061686

Conversation

@NoWon1

@NoWon1 NoWon1 commented Jul 18, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The codebase heavily used bare except: clauses which catch system-level exceptions like KeyboardInterrupt and SystemExit. This can lead to unresponsive applications and localized Denial of Service (DoS) states if a simulation loop fails to terminate cleanly.
🎯 Impact: Prevents system signals from being swallowed, allowing the simulation to terminate or halt correctly upon external interruption or critical failure.
πŸ”§ Fix: Replaced all instances of except: with except Exception: in Simulation/CancerInvasionSteppables.py.
βœ… Verification: Ran bandit to ensure no new critical issues were introduced (B112 is ignored as per instructions for CC3D spatial loops), and added a unit test using the ast module (Simulation/test_security.py) to verify no bare except blocks exist in the code. Evaluated tests with pytest.


PR created automatically by Jules for task 5542737121129061686 started by @NoWon1

… signals

Co-authored-by: NoWon1 <126711057+NoWon1@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 18, 2026 16:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants