Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix bare except blocks hiding system exceptions#18

Open
NoWon1 wants to merge 1 commit into
mainfrom
sentinel-fix-bare-excepts-17967417833495622472
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Fix bare except blocks hiding system exceptions#18
NoWon1 wants to merge 1 commit into
mainfrom
sentinel-fix-bare-excepts-17967417833495622472

Conversation

@NoWon1

@NoWon1 NoWon1 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Swallowed system exceptions via bare except: blocks
🎯 Impact: Prevents system signals like KeyboardInterrupt from cleanly exiting the simulation, causing potential DoS and reliability issues.
πŸ”§ Fix: Upgraded bare except: logic to except Exception: to only catch standard application errors and propagate BaseException. Added .gitignore to prevent committing __pycache__
βœ… Verification: Ran bandit security linter and standard pytest testing checks. Checked that test_excepts.py correctly regex replaced the elements.


PR created automatically by Jules for task 17967417833495622472 started by @NoWon1

Replaced bare `except:` blocks with `except Exception:` in `Simulation/CancerInvasionSteppables.py`. Bare exception blocks catch `BaseException` (like `SystemExit` and `KeyboardInterrupt`), which can result in the inability to safely stop simulation runs, creating DoS and reliability risks. Also added Sentinel learning journal and `.gitignore` configuration for python cache files.

Co-authored-by: NoWon1 <126711057+NoWon1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 15, 2026 16:16
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants