π‘οΈ Sentinel: [MEDIUM] Fix bare except blocks hiding system exceptions#18
π‘οΈ Sentinel: [MEDIUM] Fix bare except blocks hiding system exceptions#18NoWon1 wants to merge 1 commit into
Conversation
Replaced bare `except:` blocks with `except Exception:` in `Simulation/CancerInvasionSteppables.py`. Bare exception blocks catch `BaseException` (like `SystemExit` and `KeyboardInterrupt`), which can result in the inability to safely stop simulation runs, creating DoS and reliability risks. Also added Sentinel learning journal and `.gitignore` configuration for python cache files. Co-authored-by: NoWon1 <126711057+NoWon1@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: Swallowed system exceptions via bare
except:blocksπ― Impact: Prevents system signals like
KeyboardInterruptfrom cleanly exiting the simulation, causing potential DoS and reliability issues.π§ Fix: Upgraded bare
except:logic toexcept Exception:to only catch standard application errors and propagateBaseException. Added.gitignoreto prevent committing__pycache__β Verification: Ran
banditsecurity linter and standardpytesttesting checks. Checked thattest_excepts.pycorrectly regex replaced the elements.PR created automatically by Jules for task 17967417833495622472 started by @NoWon1