Repository navigation
return native promises from LootAsync and derive its declaration from Loot - #39
Merged
Merged
Conversation
LootAsync.create, restart and every worker call return native promises and take no callback (breaking, 7.0.0). The proxies come from the native Loot prototype, so a proxy exists exactly for each native method. index.d.ts derives LootAsync from the Loot declaration, which matches the binding: optional results and flags, the payload fields libloot sends, no masterlist members. The errors a call rejects with are exported and declared, and LogLevel is declared as the plain object it is. An optional parameter passed as null or undefined keeps its default and a required one is rejected. A PluginNotLoaded without the loaded plugins can be built, and a late init answer after a failed start is ignored. part of LAZ-1068
IDCs
changed the title
erri120
approved these changes
Sep 28, 2026
IDCs
added a commit
to Nexus-Mods/Vortex
that referenced
this pull request
Sep 30, 2026
autosort calls LootAsync's native promises directly instead of Bluebird.promisifyAll wrappers. The loot instance, the test fake and metadataLists take their types from node-loot's declaration instead of a hand-kept mirror, and the synthetic "no LOOT metadata" message carries its text in the content shape libloot sends. loot is pinned to a21cad7 until Nexus-Mods/node-loot#39 merges. part of LAZ-1068
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LootAsync.create, restart and every worker call return native promises and take no callback (breaking, 7.0.0). The proxies come from the native Loot prototype, so a proxy exists exactly for each native method. index.d.ts derives LootAsync from the Loot declaration, which matches the binding: optional results and flags, the payload fields libloot sends, no masterlist members. The errors a call rejects with are exported and declared, and LogLevel is declared as the plain object it is.
An optional parameter passed as null or undefined keeps its default and a required one is rejected. A PluginNotLoaded without the loaded plugins can be built, and a late init answer after a failed start is ignored.
part of LAZ-1068